Fix segfault in processors/parser#9283
Merged
reimda merged 6 commits intoinfluxdata:masterfrom Jun 15, 2021
Merged
Conversation
added 5 commits
May 20, 2021 12:32
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
|
Tested. Looks good for me! |
ssoroka
approved these changes
Jun 1, 2021
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
Not sure about the debug lines (see comment), but otherwise looks good
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
reimda
pushed a commit
that referenced
this pull request
Jun 17, 2021
(cherry picked from commit 6cc942f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #9282
Parsers can use the telegraf logging facility by defining a
Logfield. When using those parsers in inputs the logging facility is automatically set by telegraf after instantiation. However, in this processor the parsers are instantiated manually and setting the log facility is omitted. This in turn leads to segfault-panics for all parsers that rely on the logging facility.This PR fixes the issue by passing its (newly added) logging facility on to the parser and in this step also gets rid of the unrecommended usage of the
logpackage.Additionally, some minor improvements like making the parser private and fixing the remaining linter issues are performed.