Skip to content

update HTTP v2 listener readme#9250

Merged
sspaink merged 2 commits intorelease-1.18from
httplistener-readme
May 20, 2021
Merged

update HTTP v2 listener readme#9250
sspaink merged 2 commits intorelease-1.18from
httplistener-readme

Conversation

@sjwang90
Copy link
Copy Markdown
Contributor

@sjwang90 sjwang90 commented May 7, 2021

default config should not be set to data_format = "influx" since if users are reading in influx LP they should be using the inputs.influxdb_listener.

  • Add note about using `inputs.influxdb_listener
  • Change data format in default config to data_format.= "json"

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 7, 2021
@sjwang90 sjwang90 added the docs Issues related to Telegraf documentation and configuration descriptions label May 7, 2021
HTTP Listener v2 is a service input plugin that listens for metrics sent via
HTTP. Metrics may be sent in any supported [data format][data_format].
HTTP. Metrics may be sent in any supported [data format][data_format] unless they are
[InfluxDB Line Protocol][line_protocol]. If they are in line protocol use the [InfluxDB Listener Input Plugin][influxdb_listener] instead.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also mention influxdb_v2_listener, as that is going to be more common. Also of note that there isn't anything wrong with using this plugin for influx line protocol. it's just that the influxdb listener plugins act more like an influxdb database.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added. not sure if it's being redundant with the message in the note

@sjwang90 sjwang90 requested a review from ssoroka May 11, 2021 06:13
@sspaink sspaink merged commit e1d7eeb into release-1.18 May 20, 2021
@sspaink sspaink deleted the httplistener-readme branch May 20, 2021 20:34
reimda pushed a commit that referenced this pull request May 20, 2021
@reimda
Copy link
Copy Markdown
Contributor

reimda commented May 20, 2021

This PR was merged directly to the release-1.18 branch. Usually we merge PRs to master and only cherry pick bugfixes to release branches. I've cherry picked this to master and I'm going to remove it from release-1.18.

@sspaink
Copy link
Copy Markdown
Contributor

sspaink commented May 21, 2021

@reimda thanks for fixing this! I didn't notice it didn't go into master

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues related to Telegraf documentation and configuration descriptions feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants