Allow more characters in graphite tags#9249
Merged
helenosheaa merged 13 commits intoinfluxdata:masterfrom May 18, 2021
G-regL:master
Merged
Allow more characters in graphite tags#9249helenosheaa merged 13 commits intoinfluxdata:masterfrom G-regL:master
helenosheaa merged 13 commits intoinfluxdata:masterfrom
G-regL:master
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
helenosheaa
suggested changes
May 13, 2021
Member
helenosheaa
left a comment
There was a problem hiding this comment.
Overall looks good. Just a few comments around different naming for clarity, linter errors and not adding a bool option to allow for future extension.
Member
|
I think you could link this PR to #8877 also |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
helenosheaa
approved these changes
May 14, 2021
Member
helenosheaa
left a comment
There was a problem hiding this comment.
Looks good, thanks for making those changes so quickly!
Contributor
Author
|
No problem. I really want this feature, as I'm about to go through a massive new deployment and would love tag values to look right. Any idea what release it will apply to? |
Member
|
I think it will make it into the next feature release v1.19.0 which will be in June |
ssoroka
suggested changes
May 14, 2021
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
Looks good. the regexes are a bit dense but the test coverage looks decent. One comment from me.
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Hipska
approved these changes
May 17, 2021
ssoroka
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #9248
Added a new function to the Graphite Serializer that will use a specifc sanitzer for tags, along with supporting changes elsewhere.
As it's a relatively breaking change, it's hidden behind a (currently poorly named) feature flag called "graphite_tag_new_sanitize". That name needs to be changed, but I just can't for the life of me think of a better one.