Closing all idle connections in docker input plugin#9243
Merged
sspaink merged 1 commit intoinfluxdata:masterfrom Jun 15, 2021
Merged
Closing all idle connections in docker input plugin#9243sspaink merged 1 commit intoinfluxdata:masterfrom
sspaink merged 1 commit intoinfluxdata:masterfrom
Conversation
This prevents error "too many open files" in most cases
Contributor
|
Thanks so much for the pull request! |
1 similar comment
Contributor
|
Thanks so much for the pull request! |
Contributor
Author
|
!signed-cla |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Contributor
Author
|
Hey guys, any feedback on this small bug fix? |
akrantz01
approved these changes
Jun 7, 2021
Contributor
akrantz01
left a comment
There was a problem hiding this comment.
Thanks for the PR! Everything looks good to me.
sspaink
approved these changes
Jun 15, 2021
reimda
pushed a commit
that referenced
this pull request
Jun 17, 2021
This prevents error "too many open files" in most cases (cherry picked from commit 905b22c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents error "too many open files" in most cases
Required for all PRs:
resolves #9242
Method
Close()of official docker client just closes all idle connections and don't destroy client instance itself:https://github.com/moby/moby/blob/17.05.x/client/client.go#L181
So it's safe to use inside telegraf input plugin