Skip to content

Migrate soniah/gosnmp import to gosnmp/gosnmp#9203

Merged
sspaink merged 4 commits intoinfluxdata:masterfrom
sspaink:fixgosnmppath
May 13, 2021
Merged

Migrate soniah/gosnmp import to gosnmp/gosnmp#9203
sspaink merged 4 commits intoinfluxdata:masterfrom
sspaink:fixgosnmppath

Conversation

@sspaink
Copy link
Copy Markdown
Contributor

@sspaink sspaink commented Apr 27, 2021

This is blocking using dependabot, causing it to error out with:

Dependabot wasn't able to update github.com/soniah/gosnmp

The module path github.com/soniah/gosnmp found in your go.mod doesn't match the actual path github.com/gosnmp/gosnmp found in the dependency's go.mod.

Updating the module path in your go.mod to github.com/gosnmp/gosnmp should resolve this issue.

@sspaink sspaink requested a review from reimda April 27, 2021 18:08
reimda
reimda approved these changes Apr 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license check script is failing but otherwise looks good to me.

@sspaink
Copy link
Copy Markdown
Contributor Author

sspaink commented Apr 27, 2021 •
edited
Loading

Versions >= 1.26.0 of the package github.com/gosnmp/gosnmp break SNMPv3 auth support causing the tests to fail.
Looks like the community is working on a fix, issue tracked here: gosnmp/gosnmp#284
Before the above issue is resolved this pull request is blocked.

@sspaink sspaink mentioned this pull request Apr 27, 2021
Merged
@Hipska Hipska linked an issue May 5, 2021 that may be closed by this pull request
Update gosnmp in snmp_legacy and snmp_trap plugins #8660
Closed
This was referenced May 5, 2021
Closed
Closed
@Hipska Hipska linked an issue May 5, 2021 that may be closed by this pull request
SNMP Trap Inform #7130
Closed
@TimRots
Copy link
Copy Markdown

TimRots commented May 13, 2021

Versions >= 1.26.0 of the package github.com/gosnmp/gosnmp break SNMPv3 auth support causing the tests to fail.
Looks like the community is working on a fix, issue tracked here: gosnmp/gosnmp#284
Before the above issue is resolved this pull request is blocked.

@sspaink @Hipska gosnmp/gosnmp#284 is resolved in v.1.32.0 release.

@sspaink sspaink marked this pull request as ready for review May 13, 2021 19:26
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented May 13, 2021

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@sspaink sspaink merged commit 5330a74 into influxdata:master May 13, 2021
@sspaink sspaink mentioned this pull request May 20, 2021
Closed
@Hipska Hipska mentioned this pull request May 20, 2021
Closed
reimda pushed a commit that referenced this pull request May 20, 2021
@sspaink @reimda
Migrate soniah/gosnmp import to gosnmp/gosnmp (#9203)
1079a4d 
(cherry picked from commit 5330a74)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@sspaink @reimda
Migrate soniah/gosnmp import to gosnmp/gosnmp (influxdata#9203)
544fe2c 
(cherry picked from commit 5330a74)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
@sspaink
Migrate soniah/gosnmp import to gosnmp/gosnmp (influxdata#9203)
760478d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Hipska Hipska Hipska approved these changes

@reimda reimda reimda approved these changes

@ivorybilled ivorybilled ivorybilled approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update gosnmp in snmp_legacy and snmp_trap plugins SNMP Trap Inform

5 participants

@sspaink @TimRots @Hipska @reimda @ivorybilled