Fix apcupsd 'ALARMDEL' bug via forked repo#9195
Merged
ivorybilled merged 11 commits intomasterfrom Apr 28, 2021
Merged
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
ssoroka
reviewed
Apr 27, 2021
ssoroka
approved these changes
Apr 27, 2021
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
reimda
pushed a commit
that referenced
this pull request
Apr 28, 2021
* add oauth2 to http input * switch APC UPSD dependency to forked version with bug fixed. * fix branch discrepancies * fix branch discrepancies * fix branch discrepancies * fix branch discrepancies * fork to influxdata repo (cherry picked from commit d181b43)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* add oauth2 to http input * switch APC UPSD dependency to forked version with bug fixed. * fix branch discrepancies * fix branch discrepancies * fix branch discrepancies * fix branch discrepancies * fork to influxdata repo (cherry picked from commit d181b43)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Aug 28, 2025
* add oauth2 to http input * switch APC UPSD dependency to forked version with bug fixed. * fix branch discrepancies * fix branch discrepancies * fix branch discrepancies * fix branch discrepancies * fork to influxdata repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making this fix because our
apcupsdplugin is currently broken right now if certain settings are on on the APC UPS device. As the issue we made in theapcupsdgo library repo was unable to be addressed (for now), this PR switches our dependency to a forked version of theapcupsdrepo that handles the broken case. Here is the fix that was made.This resolves #8521
Once this bug is fixed in the main repo, we should switch our
go.moddependency to use that again.