Add time.now() starlark processor example test#9133
Merged
ivorybilled merged 1 commit intomasterfrom Apr 19, 2021
Merged
Conversation
srebhan
reviewed
Apr 19, 2021
Comment on lines
-66
to
+67
| return loadFunc(module, s.Log) | ||
| return s.starlarkLoadFunc(module, s.Log) |
Member
There was a problem hiding this comment.
What is the reason behind this?
srebhan
reviewed
Apr 19, 2021
srebhan
reviewed
Apr 19, 2021
Member
srebhan
left a comment
There was a problem hiding this comment.
The code looks good, but I'd like to prevent messing with the load function if possible. Can you please check if you can set times NowFunc` in the tests instead of overriding the load!?
ssoroka
approved these changes
Apr 19, 2021
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
looks good. I think there's issues with replacing the load function because the module is loaded at runtime. Looks fine the way it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to mock the time.now() function in starlark and thus be able to create an example in which time.now() is used to set on metrics.