Add custom docker image info to nvidia plugin#9124
Merged
helenosheaa merged 2 commits intomasterfrom Apr 14, 2021
Merged
Conversation
Contributor
|
I'm not sure that this is the only method, it's probably possible to use volume mount binding to inject the required binary without rebuilding the docker container. |
Member
Author
|
@ssoroka Ok I've added about mount binding as an alternative option in there also with a link to the relevant docker page. |
ivorybilled
approved these changes
Apr 13, 2021
ssoroka
approved these changes
Apr 13, 2021
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
this is probably correct. bwahaha
|
May I make my own PR instead of this one with more detailed information? |
Member
Author
|
@BlueskyFR if you have a docker example you can add to the plugin folder we'd be happy to review a PR for it. I think it's also worth keeping this change to the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #8531
Add context on how to use nvidia plugin with a custom nvidia/cuda docker image