Skip to content

Fix opcua integration test#9107

Merged
helenosheaa merged 2 commits intoinfluxdata:masterfrom
R290:master
Apr 9, 2021
Merged

Fix opcua integration test#9107
helenosheaa merged 2 commits intoinfluxdata:masterfrom
R290:master

Conversation

@R290
Copy link
Copy Markdown
Contributor

@R290 R290 commented Apr 8, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

Related to #8737

Changed remote opcua.rocks domain to docker container on localhost. The docker image is the same as the original server on opcua.rocks uses: open62541/open62541. See https://opcua.rocks/open62541-online-test-server/ for additional info.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 8, 2021
Copy link
Copy Markdown
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add in the skip for the test in short mode, as we currently don't have the setup to run docker dependent integration tests on circleci. Also could you remove the resolves keyword as it will close the issue when we merge this PR and there are the other items on the issue.

@R290 R290 requested a review from helenosheaa April 9, 2021 17:41
Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@helenosheaa helenosheaa merged commit 114e4c2 into influxdata:master Apr 9, 2021
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants