Skip to content

Speed up package step by running in parallel.#9096

Merged
ivorybilled merged 17 commits intomasterfrom
testMakeBranch
Apr 21, 2021
Merged

Speed up package step by running in parallel.#9096
ivorybilled merged 17 commits intomasterfrom
testMakeBranch

Conversation

@ivorybilled
Copy link
Copy Markdown
Contributor

@ivorybilled ivorybilled commented Apr 6, 2021

resolves #9098

Before this change, a full check suite on a PR took about 30-33 minutes. After this change, I've seen consistent results around 19 minutes. Note that the make package command will no longer work for generating all packages, each OS type has to be specified in an argument (such as windows=1 make package). This will also require an update to telegraf tiger which will be a separate PR.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 6, 2021
Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivorybilled ivorybilled changed the title Testing Artifact Builds - (Draft, ignore) Speed up package step by running in parallel. Apr 9, 2021
@ivorybilled ivorybilled marked this pull request as ready for review April 9, 2021 14:48
Copy link
Copy Markdown
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to make sense

@ivorybilled ivorybilled merged commit ad94205 into master Apr 21, 2021
@ivorybilled ivorybilled deleted the testMakeBranch branch April 21, 2021 17:32
@Hipska
Copy link
Copy Markdown
Contributor

Hipska commented May 4, 2021

Also seems to introduce problems: #9233

@reimda reimda mentioned this pull request Jun 2, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
* test

* more test

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Update Makefile

* Update Makefile

* Update Makefile

* Update Makefile

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance speed of 'package' job while building PRs with Parallelization

4 participants