Skip to content

Addresses issues in PR 4928#9087

Merged
helenosheaa merged 3 commits intomasterfrom
4928
Jun 1, 2021
Merged

Addresses issues in PR 4928#9087
helenosheaa merged 3 commits intomasterfrom
4928

Conversation

@jessingrass
Copy link
Copy Markdown
Contributor

@jessingrass jessingrass commented Apr 2, 2021

I've added the code to allow for different formats in json_timestamp_parser.

  • Updated associated README.md.
  • Wrote appropriate unit tests. (mid-way through this process)

resolves #4928

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 2, 2021
@jessingrass jessingrass requested a review from ivorybilled April 2, 2021 16:38
Comment on lines +483 to +484
timestamp: "Mon Jan _2 15:04:05 2006",
expected: ansic("Mon Jan _2 15:04:05 2006"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the underscores

Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan self-assigned this Apr 19, 2021
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 1, 2021
@helenosheaa helenosheaa merged commit ad6d25a into master Jun 1, 2021
@helenosheaa helenosheaa deleted the 4928 branch June 1, 2021 21:05
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow timestamp RFC names in json parser's json_time_format

4 participants