Skip to content

Fix inputs.snmp init when no mibs installed#9050

Merged
reimda merged 2 commits intoinfluxdata:masterfrom
Super-Visions:snmp/field-init
Mar 30, 2021
Merged

Fix inputs.snmp init when no mibs installed#9050
reimda merged 2 commits intoinfluxdata:masterfrom
Super-Visions:snmp/field-init

Conversation

@Hipska
Copy link
Copy Markdown
Contributor

@Hipska Hipska commented Mar 25, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

The snmp plugin would log translating errors if the required mibs are not installed, even when a lookup is not actually needed, because the user has the numerical oid and name already configured.

Now the plugin will not attempt a lookup if these are configured like that.

@Hipska Hipska requested a review from reimda March 25, 2021 17:13
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 25, 2021
Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hipska Hipska added area/snmp plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 26, 2021
Copy link
Copy Markdown
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the linter error, this looks good to me.

Co-authored-by: reimda <reimda@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reimda reimda merged commit 66c6396 into influxdata:master Mar 30, 2021
reimda pushed a commit that referenced this pull request Apr 7, 2021
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
@Hipska Hipska deleted the snmp/field-init branch April 20, 2021 06:57
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/snmp fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants