Merged
Conversation
ssoroka
reviewed
Feb 22, 2021
ssoroka
approved these changes
Feb 22, 2021
Contributor
Author
|
Updated to keep somewhat of the 'optimization' by adding the lock only to parseName. From my various tests, this works as well. |
Contributor
Author
|
!retry-checks |
4 similar comments
Contributor
Author
|
!retry-checks |
Contributor
Author
|
!retry-checks |
Contributor
Author
|
!retry-checks |
Contributor
Author
|
!retry-checks |
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* Fix the issue * Remove test I was using for replication * Accidentally removed test. * Add lock only where it is necessary. * eliminate unnecessary space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was inadvertently caused by a small optimization I attempted to make in a previous PR, simply resetting that change here.
Closes #8695