Skip to content

Move windows tests to circle-ci, remove appveyor#8844

Merged
sspaink merged 4 commits intoinfluxdata:masterfrom
sspaink:windowstests
Feb 10, 2021
Merged

Move windows tests to circle-ci, remove appveyor#8844
sspaink merged 4 commits intoinfluxdata:masterfrom
sspaink:windowstests

Conversation

@sspaink
Copy link
Copy Markdown
Contributor

@sspaink sspaink commented Feb 9, 2021

Only the windows tests are run in appveyor, moved the execution of the tests to circle-ci config so we can have only one CI system.

Copy link
Copy Markdown
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@sspaink sspaink changed the title windows tests to circleci Move windows tests to circle-ci, remove appveyor Feb 9, 2021
@sspaink sspaink marked this pull request as ready for review February 9, 2021 22:20
Copy link
Copy Markdown
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We probably ought to run it nightly too since the other platforms do.

Copy link
Copy Markdown
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @sspaink Would you let the rest of the team know before we switch over, maybe on community slack #telegraf-dev? Then would you deactivate the appveyor webhooks and merge this? Deactivating the webhooks instead of deleting will give us the chance to revert if we have to for some reason.

To deactivate them, go into the github repo settings and webhooks section then edit the webhook and uncheck the active checkbox (at the very bottom) and click "update webhook".

@sspaink sspaink merged commit 3a66b57 into influxdata:master Feb 10, 2021
@sspaink
Copy link
Copy Markdown
Contributor Author

sspaink commented Feb 10, 2021

@reimda thanks for the review! I've disabled appveyor webhooks in the settings and posted to #telegraf-dev.

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
* windows tests to circleci

* Add as requirement to package/release

* Use latest windows orb

* Add to nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants