Skip to content

Increase build verbosity with go mod download -x#8496

Merged
ssoroka merged 1 commit intoinfluxdata:masterfrom
lesam:add-mod-download-x
Feb 5, 2021
Merged

Increase build verbosity with go mod download -x#8496
ssoroka merged 1 commit intoinfluxdata:masterfrom
lesam:add-mod-download-x

Conversation

@lesam
Copy link
Copy Markdown
Contributor

@lesam lesam commented Dec 2, 2020

Initial build took several minutes on my machine, and it looked like it
was hanging until I added the -x flag.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@p-zak
Copy link
Copy Markdown
Collaborator

p-zak commented Dec 2, 2020

The -x flag causes download to print the commands download executes.
I wonder how this helped you.

But what is more important: this flag was added in Go 1.14. And seems that CI checks for Mac/Darwin uses 1.13.6.

Similar problem (with Go in 1.13.6) was encounter here: #8391

@lesam
Copy link
Copy Markdown
Contributor Author

lesam commented Dec 2, 2020

The -x flag causes download to print the commands download executes.
I wonder how this helped you.

But what is more important: this flag was added in Go 1.14. And seems that CI checks for Mac/Darwin uses 1.13.6.

Similar problem (with Go in 1.13.6) was encounter here: #8391

Darn.

The -x flag helps because I can know that go mod download is actually doing something instead of just wondering why it is hanging for minutes - if there are no modules to download it's pretty quiet, so I think it would be an improvement for people new to the project.

How long will 1.13 be supported? I can withdraw the PR and maybe re-raise when 1.13 support is dropped.

@lesam
Copy link
Copy Markdown
Contributor Author

lesam commented Dec 2, 2020

Actually, judging by that comment looks like the circleci change for macdeps to 1.14 is coming soon: #8391 (comment) . So I'll leave this up.

@lesam
Copy link
Copy Markdown
Contributor Author

lesam commented Dec 2, 2020

Cherry-picked the commit from the other PR to bump the go version in macdeps

@ssoroka
Copy link
Copy Markdown
Contributor

ssoroka commented Dec 2, 2020

That's probably the last holdout from Go 1.13, and I suspect we can merge this without further problems

@reimda
Copy link
Copy Markdown
Contributor

reimda commented Dec 3, 2020

Hi Sam, thanks for the PR.

I don't want to merge the 'brew update' change because it adds 4-5 minutes to the build. I think circleci provides a newer mac image than we're using. If we can switch to a new image instead of updating the old one, we should get golang 1.14+ without increased build time.

I'll look into switching to a new image today so we can merge this and #8391.

@lesam lesam force-pushed the add-mod-download-x branch from d0947e8 to 86fa81c Compare December 3, 2020 22:13
lesam
lesam commented Dec 3, 2020
View reviewed changes
.circleci/config.yml Outdated
mac: &mac
macos:
xcode: 11.3.1
xcode: 12.2.0
Copy link
Copy Markdown
Contributor Author

@lesam lesam Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playing around with circleci to make sure I understand it - this bumps the macos version (see commit message).

@reimda reimda mentioned this pull request Dec 4, 2020
Merged
@reimda
Copy link
Copy Markdown
Contributor

reimda commented Dec 4, 2020

I updated the golang version for mac ci in #8516. Could you remove changes to .circleci/config.yml and rebase this PR? Thanks!

@lesam lesam force-pushed the add-mod-download-x branch from 86fa81c to 4ee371e Compare December 7, 2020 18:51
@lesam
Copy link
Copy Markdown
Contributor Author

lesam commented Dec 7, 2020

I updated the golang version for mac ci in #8516. Could you remove changes to .circleci/config.yml and rebase this PR? Thanks!

Done

@lesam lesam force-pushed the add-mod-download-x branch from 4ee371e to 1d532d6 Compare December 9, 2020 15:02
@lesam
Copy link
Copy Markdown
Contributor Author

lesam commented Dec 9, 2020

Rebased

@helenosheaa helenosheaa added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 4, 2021
@lesam
Increase build verbosity with go mod download -x
8b0709e 
Initial build took several minutes on my machine, and it looked like it
was hanging until I added the -x flag.
@lesam lesam force-pushed the add-mod-download-x branch from 1d532d6 to 8b0709e Compare February 5, 2021 13:58
@lesam
Copy link
Copy Markdown
Contributor Author

lesam commented Feb 5, 2021

Rebased again

@ssoroka ssoroka merged commit 86e50f8 into influxdata:master Feb 5, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@lesam
Increase build verbosity with go mod download -x (influxdata#8496)
291100e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ssoroka ssoroka ssoroka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lesam @p-zak @ssoroka @reimda @helenosheaa