proxmox: ignore QEMU templates and iron out a few bugs#8326
Merged
ssoroka merged 1 commit intoinfluxdata:masterfrom Nov 12, 2020
krzysdabro:proxmox-ignore-templates
Merged
proxmox: ignore QEMU templates and iron out a few bugs#8326ssoroka merged 1 commit intoinfluxdata:masterfrom krzysdabro:proxmox-ignore-templates
ssoroka merged 1 commit intoinfluxdata:masterfrom
krzysdabro:proxmox-ignore-templates
Conversation
Contributor
Author
|
@ssoroka @danielnelson Can you review this PR? |
ssoroka
approved these changes
Nov 12, 2020
Comment on lines
56
to
59
| if px.NodeName == "" { | ||
| return errors.New("node_name must be configured") | ||
| hostname, _ := os.Hostname() | ||
| px.NodeName = hostname | ||
| } |
Contributor
There was a problem hiding this comment.
Just a thought, if you move this to the init() function below, you don't need the "" check, and it'll allow users to unset it if they don't want it
ssoroka
pushed a commit
that referenced
this pull request
Nov 13, 2020
(cherry picked from commit fb463bc)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Error->Errorf)node_name not foundtosearch domain is not setnode_nameRequired for all PRs: