SQL Server - on-prem queries refactor (again)#8323
Merged
ssoroka merged 1 commit intoinfluxdata:masterfrom Oct 27, 2020
Merged
Conversation
ssoroka
approved these changes
Oct 27, 2020
Contributor
|
probably a bad conflict resolution somewhere. Do you want this in 1.16.1? |
Contributor
Author
Yes |
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Sorry to bother you (again) with this @ssoroka but I've noticed this just now.
looks like that the edits made with #8172 to the main file of the sqlserver on prem queries have been lost in the merge... somehow.
If I go to that or (#8172) I can see that only 2 files have been edited, and "plugins/inputs/sqlserver/sqlserverqueries.go" is not included.
Therefore I made this PR to re-add all the missing formatting and edits that had been made to that file