RAS plugin - fix for too many open files handlers#8306
Merged
ssoroka merged 2 commits intoinfluxdata:masterfrom Oct 23, 2020
Merged
RAS plugin - fix for too many open files handlers#8306ssoroka merged 2 commits intoinfluxdata:masterfrom
ssoroka merged 2 commits intoinfluxdata:masterfrom
Conversation
ssoroka
reviewed
Oct 23, 2020
ssoroka
approved these changes
Oct 23, 2020
ssoroka
pushed a commit
that referenced
this pull request
Oct 28, 2020
(cherry picked from commit 6923001)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Details
Database driver doesn't close file handler properly when
db.Close()is called.This may lead to
too many open filesfor Telegraf process (returned by OS).In this fix
sql.Open()is called once inStart()anddb.Close()is also called only once inStop().This is also optimization (open DB just once, not in every
Gather()) and following along guide from comment forfunc (db *DB) Close() errorinsql.go:The same approach was introduced in
inputs/postgresqlplugin.