#8295 Initial Yandex.Cloud monitoring#8296
Merged
ssoroka merged 4 commits intoinfluxdata:masterfrom Nov 2, 2020
peter-volkov:master
Merged
#8295 Initial Yandex.Cloud monitoring#8296ssoroka merged 4 commits intoinfluxdata:masterfrom peter-volkov:master
ssoroka merged 4 commits intoinfluxdata:masterfrom
peter-volkov:master
Conversation
p-zak
reviewed
Oct 23, 2020
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go
Outdated
Show resolved
Hide resolved
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go
Outdated
Show resolved
Hide resolved
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@p-zak can you please take another look? |
Collaborator
LGTM! |
Contributor
Author
|
@p-zak thank you. Who can merge the PR? |
Collaborator
ssoroka
suggested changes
Oct 30, 2020
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go
Outdated
Show resolved
Hide resolved
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go
Outdated
Show resolved
Hide resolved
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go
Outdated
Show resolved
Hide resolved
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring_test.go
Outdated
Show resolved
Hide resolved
Contributor
|
Looking pretty good. I have a few more change requests. |
ssoroka
reviewed
Nov 2, 2020
ssoroka
reviewed
Nov 2, 2020
ssoroka
reviewed
Nov 2, 2020
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
Looks good. I've requested a few small edits, and then we can get this merged.
plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go
Outdated
Show resolved
Hide resolved
ssoroka
approved these changes
Nov 2, 2020
Contributor
|
Thanks! Will merge as soon as the tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs: