Fix wrong memory measurements of containers and vms#8290
Merged
ssoroka merged 3 commits intoinfluxdata:masterfrom Oct 21, 2020
tlusser-inv:master
Merged
Fix wrong memory measurements of containers and vms#8290ssoroka merged 3 commits intoinfluxdata:masterfrom tlusser-inv:master
ssoroka merged 3 commits intoinfluxdata:masterfrom
tlusser-inv:master
Conversation
Contributor
Author
|
Linked PR to issue #8291 |
ssoroka
suggested changes
Oct 20, 2020
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
looks good. I'd like to avoid the NodeName blank check before merge. see comment.
| } | ||
| tags := getTags(px, vmStat.Name, vmConfig, rt) | ||
| fields, err := getFields(vmStat) | ||
| currentVMStatus, err := getCurrentVMStatus(px, rt, vmStat.ID) |
Contributor
There was a problem hiding this comment.
Just a note that this adds an http request inside a loop. It's going to have some negative performance implications, especially on systems with a large number of VMs. If there's any way to get this data in aggregate with one call, that would be preferable.
Contributor
Author
There was a problem hiding this comment.
We are aware of this, but AFAIK there is no other possibility in the REST-API to query the status of all virtual machines/containers in one step (please see: https://pve.proxmox.com/pve-docs/api-viewer/)
ssoroka
approved these changes
Oct 21, 2020
Contributor
|
Awesome, Thanks! |
reimda
pushed a commit
that referenced
this pull request
Oct 21, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs: