Conversation
Contributor
|
lgtm |
ssoroka
approved these changes
Oct 16, 2020
ssoroka
pushed a commit
that referenced
this pull request
Oct 16, 2020
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Feb 2, 2023
This ensures that cgo is always disabled with builds using the Makefile. Telegraf does not support importing C libraries or depending on any of them in the first place. This is to ensure cross-platform and cross-OS support. Our official builds for Windows, macOS, and BSD are cross-compiled. In these cases, cgo is already disabled. This primarily affects the linux builds. This will enable us to deliver the much requested arm64 docker images for Alpine. In influxdata#8278, a check for the glibc version was added after a user noticed the binary was depending on newer versions of glibc. This removes those checks as static builds will not need these checks. Finally, this removes the no longer necessary static specific build.
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Feb 2, 2023
This ensures that cgo is always disabled with builds using the Makefile. Telegraf does not support importing C libraries or depending on any of them in the first place. This is to ensure cross-platform and cross-OS support. Our official builds for Windows, macOS, and BSD are cross-compiled. In these cases, cgo is already disabled. This primarily affects the linux builds. This will enable us to deliver the much requested arm64 docker images for Alpine. In influxdata#8278, a check for the glibc version was added after a user noticed the binary was depending on newer versions of glibc. This removes those checks as static builds will not need these checks. Finally, this removes the no longer necessary static specific build.
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Feb 2, 2023
This ensures that cgo is always disabled with builds using the Makefile. Telegraf does not support importing C libraries or depending on any of them in the first place. This is to ensure cross-platform and cross-OS support. Our official builds for Windows, macOS, and BSD are cross-compiled. In these cases, cgo is already disabled. This primarily affects the linux builds. This will enable us to deliver the much requested arm64 docker images for Alpine. In influxdata#8278, a check for the glibc version was added after a user noticed the binary was depending on newer versions of glibc. This removes those checks as static builds will not need these checks. Finally, this removes the no longer necessary static specific build.
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Feb 2, 2023
This ensures that cgo is always disabled with builds using the Makefile. Telegraf does not support importing C libraries or depending on any of them in the first place. This is to ensure cross-platform and cross-OS support. Our official builds for Windows, macOS, and BSD are cross-compiled. In these cases, cgo is already disabled. This primarily affects the linux builds. This will enable us to deliver the much requested arm64 docker images for Alpine. In influxdata#8278, a check for the glibc version was added after a user noticed the binary was depending on newer versions of glibc. This removes those checks as static builds will not need these checks. Finally, this removes the no longer necessary static specific build.
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Feb 2, 2023
This ensures that cgo is always disabled with builds using the Makefile. Telegraf does not support importing C libraries or depending on any of them in the first place. This is to ensure cross-platform and cross-OS support. Our official builds for Windows, macOS, and BSD are cross-compiled. In these cases, cgo is already disabled. This primarily affects the linux builds. This will enable us to deliver the much requested arm64 docker images for Alpine. In influxdata#8278, a check for the glibc version was added after a user noticed the binary was depending on newer versions of glibc. This removes those checks as static builds will not need these checks. Finally, this removes the no longer necessary static specific build.
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version check makes sure that telegraf on linux platforms doesn't dynamically link to a glibc that is too new. Requiring a new glibc would cause telegraf to fail to run on older supported linux distributions. The version it compares against is configurable in the makefile and set to 2.17 which is what RHEL 7 provides.
The check runs as part of the makefile's packages target which already runs during CI, so this will run on every PR.
CI for this PR is failing intentionally to show that it works.