Conversation
|
I wish gzip would have been the default from the beginning but I have reservations about changing the default at this point. It was uncompressed from the beginning of telegraf (almost 5 years ago) and default uncompressed since the content encoding option was added 3 years ago. It should be safe in most cases to switch to gzip, but there are cases where it might not be, such as when the device running telegraf was sized with the expectation of low cpu usage (think embedded device or small virtual instance on a cloud provider). The same goes for influxdb which has to gunzip if telegraf is sending gzipped. I like the idea of gradually defaulting to gzip. The v2 output is already default gzip, so people upgrading that way will get it. I'd also be be fine changing the v1 output default to gzip in a major release (2.0) where backwards compatibility isn't as expected as a minor release (1.x). I haven't seen a lot of user reports of uncompressed v1 being a problem. You mentioned one case in #7397 (comment) where enabling gzip helped. I don't think it's worth the risk when people aren't asking for it. |
|
I understand where you're coming from, but the potential gains here outweigh any potential risk, especially since you can opt to turn it off. Anyone who has set this setting explicitly will not be affected, and we can document the change. Some other things to consider:
lastly, we can't be afraid that we might make performance worse for a few people with underpowered devices at the cost of performance at high-volume for the majority. |
resolves #7397