Conversation
sjwang90
commented
Oct 14, 2020
| ## This value is propagated to pqos tool. Interval format is defined by pqos itself. | ||
| ## If not provided or provided 0, will be set to 10 = 10x100ms = 1s. | ||
| # sampling_interval = "10" | ||
| [[inputs.intel_rdt]] |
Contributor
Author
There was a problem hiding this comment.
@p-zak can you clarify the name of this plugin? Will need to be updated in the SampleConfig() section of intel_rdt.go
Contributor
There was a problem hiding this comment.
fyi this plugin name line doesn't go in SampleConfig.
Collaborator
There was a problem hiding this comment.
@sjwang90 Yes, it should be intel_rdt. I think it should also be changed in https://github.com/influxdata/telegraf/blob/master/plugins/inputs/intel_rdt/intel_rdt.go#L544 and we are all set :)
Collaborator
|
@sjwang90 looks much nicer, thank you. I still need check one or two things, can we back to it tomorrow? |
Contributor
Author
|
Yeah no rush! |
Collaborator
|
@sjwang90 LGTM! |
Contributor
Author
ssoroka
pushed a commit
that referenced
this pull request
Oct 15, 2020
* cleanup Intel RDT readme * Update intel_rdt.go
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* cleanup Intel RDT readme * Update intel_rdt.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great detailed README but some feedback from some of our documentation folks to make this README a little clearer/cleaner.
@p-zak Please review