Conversation
add min telegraf versions to readme for new plugins
p-zak
reviewed
Oct 6, 2020
Collaborator
p-zak
left a comment
There was a problem hiding this comment.
In addition to my comments to changed files, I did a quick check and following new plugins were added after 1.15 release and are missing in this PR:
| to one of `ns`, `us`, `ms`, `s`. All other parameters are ignored and | ||
| defer to the output plugins configuration. | ||
|
|
||
| Telegraf minimum version: Telegraf 1.16.0 |
Collaborator
There was a problem hiding this comment.
influxdb_v2_listener should have been included in main README.md
Merged here: #7828
|
|
||
| The proxmox plugin gathers metrics about containers and VMs using the Proxmox API. | ||
|
|
||
| Telegraf minimum version: Telegraf 1.16.0 |
Collaborator
There was a problem hiding this comment.
proxmox should have been included in main README.md
Merged here: #7922
|
|
||
| Telegraf should have Administrator permissions to subscribe for some of the Windows Events Channels, like System Log. | ||
|
|
||
| Telegraf minimum version: Telegraf 1.16.0 |
Collaborator
There was a problem hiding this comment.
win_eventlog should have been included in main README.md
Merged here: #8000
Contributor
Author
|
Thanks for finding these @p-zak!!! |
Collaborator
|
@sjwang90 no problem, but READMEs for these plugins were not filled with proper Telegraf minimum version:
|
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* add min telegraf versions to readme * add new telegraf plugins to main readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add min telegraf versions to readme for new plugins