Skip to content

Add more missing NVMe attributes to smart plugin#8113

Merged
ssoroka merged 10 commits intoinfluxdata:masterfrom
p-zak:smart_nvme
Sep 28, 2020
Merged

Add more missing NVMe attributes to smart plugin#8113
ssoroka merged 10 commits intoinfluxdata:masterfrom
p-zak:smart_nvme

Conversation

@p-zak
Copy link
Copy Markdown
Collaborator

@p-zak p-zak commented Sep 11, 2020

Required for all PRs:

  • Signed CCLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

CCLA completed and signed by Intel Corporation (I hope ICLA is not required since this github account is business account).

This PR solves #8085

Feature Request

We would like to add support for reading additional NVMe attributes to smart plugin.
New attributes from NVMe Specification 1.4 we want to add:

  • Temperature Sensor 1
  • Temperature Sensor 2
  • Temperature Sensor 3
  • Temperature Sensor 4
  • Temperature Sensor 5
  • Temperature Sensor 6
  • Temperature Sensor 7
  • Temperature Sensor 8
  • Thermal Management Temperature 1 Transition Count
  • Thermal Management Temperature 2 Transition Count
  • Total Time For Thermal Management Temperature 1
  • Total Time For Thermal Management Temperature 2

Moreover, we would like to add support for NVMe vendor specific attributes on an example of INTEL® device in accordance with INTEL® SSD SMART metrics for NVMe devices.

Plan is to add support for reading following attributes:

  • Program Fail Count
  • Erase Fail Count
  • Wear Leveling Count
  • End to End Error Detection Count
  • CRC Error Count
  • Timed Workload, Media Wear
  • Timed Workload, Host Reads
  • Timed Workload, Timer
  • Thermal Throttle Status
  • Retry Buffer Overflow Counter
  • PLL Lock Loss Count
  • NAND Bytes Written
  • Host Bytes Written

Generic attributes from NVMe Specification 1.4 are still gathered by smartctl tool.
NVMe vendor specific attributes are optionally gathered by nvme-cli if it exists in OS.

@sjwang90 sjwang90 added feature request Requests for new plugin and for new features to existing plugins area/smart labels Sep 16, 2020
Copy link
Copy Markdown
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome. Couple small change requests and I'm good to merge it.

@p-zak p-zak requested a review from ssoroka September 25, 2020 21:03
@p-zak
Copy link
Copy Markdown
Collaborator Author

p-zak commented Sep 25, 2020

Really awesome. Couple small change requests and I'm good to merge it.

@ssoroka Small changes delivered! If you are ok with them, you can merge whenever is fine for you 👍

@p-zak p-zak closed this Sep 25, 2020
@p-zak p-zak reopened this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/smart feature request Requests for new plugin and for new features to existing plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants