Add more missing NVMe attributes to smart plugin#8113
Merged
ssoroka merged 10 commits intoinfluxdata:masterfrom Sep 28, 2020
Merged
Add more missing NVMe attributes to smart plugin#8113ssoroka merged 10 commits intoinfluxdata:masterfrom
ssoroka merged 10 commits intoinfluxdata:masterfrom
Conversation
ssoroka
suggested changes
Sep 24, 2020
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
Really awesome. Couple small change requests and I'm good to merge it.
Collaborator
Author
@ssoroka Small changes delivered! If you are ok with them, you can merge whenever is fine for you 👍 |
ssoroka
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
CCLA completed and signed by Intel Corporation (I hope ICLA is not required since this github account is business account).
This PR solves #8085
Feature Request
We would like to add support for reading additional NVMe attributes to smart plugin.
New attributes from NVMe Specification 1.4 we want to add:
Moreover, we would like to add support for NVMe vendor specific attributes on an example of INTEL® device in accordance with INTEL® SSD SMART metrics for NVMe devices.
Plan is to add support for reading following attributes:
Generic attributes from NVMe Specification 1.4 are still gathered by smartctl tool.
NVMe vendor specific attributes are optionally gathered by nvme-cli if it exists in OS.