Skip to content

Carbon2 configuration option - include field in metric name#8094

Merged
ssoroka merged 4 commits intoinfluxdata:masterfrom
SumoLogic:carbon2-include-field-name-in-metric-pr
Sep 10, 2020
Merged

Carbon2 configuration option - include field in metric name#8094
ssoroka merged 4 commits intoinfluxdata:masterfrom
SumoLogic:carbon2-include-field-name-in-metric-pr

Conversation

@pmalek-sumo
Copy link
Copy Markdown
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Copy link
Copy Markdown
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have a minor suggestion for the readme.

@pmalek-sumo pmalek-sumo force-pushed the carbon2-include-field-name-in-metric-pr branch from b9d528e to d585bb4 Compare September 9, 2020 16:13
@pmalek-sumo pmalek-sumo requested a review from ssoroka September 10, 2020 16:08
@pmalek-sumo
Copy link
Copy Markdown
Contributor Author

It seems all tests have passed and this is ready to be merged 👍🏻

Copy link
Copy Markdown
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@ssoroka ssoroka merged commit 5534b99 into influxdata:master Sep 10, 2020
@pmalek-sumo pmalek-sumo deleted the carbon2-include-field-name-in-metric-pr branch September 10, 2020 16:23
pmalek-sumo added a commit to SumoLogic/telegraf that referenced this pull request Sep 28, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants