Add agent host tag configuration option#8082
Merged
ssoroka merged 2 commits intoinfluxdata:masterfrom Oct 8, 2020
Merged
Conversation
The host of the device being monitored is hardcoded and it is stored under "agent_host" tag. Make this variable configurable in order to avoid post processing.
ssoroka
approved these changes
Sep 8, 2020
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
Looks pretty good. You've got some build failures though. Looks like you need to run gofmt on the files changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent hostname is hardcoded in agent_host tag. Expose this as a variable and make it configurable in order to avoid extra processing later on.
Required for all PRs:
In reply to feature request #8060