Skip to content

Add response_time to monit plugin#8056

Merged
ssoroka merged 7 commits intoinfluxdata:masterfrom
KalvadTech:improve_monit
Nov 23, 2020
Merged

Add response_time to monit plugin#8056
ssoroka merged 7 commits intoinfluxdata:masterfrom
KalvadTech:improve_monit

Conversation

@wowi42
Copy link
Copy Markdown
Contributor

@wowi42 wowi42 commented Aug 30, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Copy link
Copy Markdown

@soufiane-bouchaara soufiane-bouchaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me , I was waiting for this update

@sjwang90 sjwang90 changed the title Improve monit Add response_time to monit plugin Aug 31, 2020
@sjwang90
Copy link
Copy Markdown
Contributor

@SirishaGopigiri if you'd like to take a look.

@sjwang90 sjwang90 added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 31, 2020
@wowi42
Copy link
Copy Markdown
Contributor Author

wowi42 commented Aug 31, 2020

not sure if the failed test is linked to my update...

@srebhan
Copy link
Copy Markdown
Member

srebhan commented Sep 1, 2020

Please rebase on master to fix the AppVeyor problem.

@wowi42
Copy link
Copy Markdown
Contributor Author

wowi42 commented Sep 7, 2020

@srebhan I think it's ok now, right?

@srebhan
Copy link
Copy Markdown
Member

srebhan commented Sep 7, 2020

@wowi42 if it builds it's ok! ;-)

@wowi42
Copy link
Copy Markdown
Contributor Author

wowi42 commented Sep 7, 2020

@srebhan It seems so, no?

@srebhan
Copy link
Copy Markdown
Member

srebhan commented Sep 7, 2020

Yes, it's building ok now.

@wowi42
Copy link
Copy Markdown
Contributor Author

wowi42 commented Oct 14, 2020

Any plan to merge it?

@sjwang90 sjwang90 requested a review from ssoroka October 14, 2020 18:20
Copy link
Copy Markdown
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be something wrong with this PR, it has a bunch of unrelated changes.

@wowi42
Copy link
Copy Markdown
Contributor Author

wowi42 commented Nov 3, 2020

fixed @ssoroka

Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssoroka seems like the unrelated changes are gone. LGTM.

@srebhan srebhan self-assigned this Nov 21, 2020
@ssoroka ssoroka merged commit d64c722 into influxdata:master Nov 23, 2020
@ssoroka
Copy link
Copy Markdown
Contributor

ssoroka commented Nov 23, 2020

Thank you! merged

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants