Skip to content

Update README.md#8049

Merged
ssoroka merged 1 commit intoinfluxdata:masterfrom
Alestrix:patch-1
Oct 13, 2020
Merged

Update README.md#8049
ssoroka merged 1 commit intoinfluxdata:masterfrom
Alestrix:patch-1

Conversation

@Alestrix
Copy link
Copy Markdown
Contributor

@Alestrix Alestrix commented Aug 28, 2020

Adding info from #3520. Thanks to this undocumented behavior I can throw away a bunch of data now.

Don't know what a CLA is and don't know how to sign it.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • [ N/A ] Has appropriate unit tests.

Adding info from #3520. Thanks to this undocumented behavior I can throw away a bunch of data now.
@ssoroka
Copy link
Copy Markdown
Contributor

ssoroka commented Aug 28, 2020

that seems like... unexpected behavior. I don't know how that could possibly do the right thing.
Ah. it makes sense if all the scripts are separate.
It might be good to make this configurable. Alternatively you'd have to move everything into a script file and run that... which I guess is okay.

@sjwang90 sjwang90 added area/exec docs Issues related to Telegraf documentation and configuration descriptions labels Sep 3, 2020
@Alestrix
Copy link
Copy Markdown
Contributor Author

Alestrix commented Sep 6, 2020

The issue with a script file is that the resulting output would be multiple concatenated JSON strings, which is not a correct JSON string anymore. So I need to keep the commands separate and add delays in the hopes that the previous command is finished by then.

Running those in parallel is IMHO a horrible design decision.

@Alestrix
Copy link
Copy Markdown
Contributor Author

Alestrix commented Sep 6, 2020

Shouldn't cause this line the commands to run after each other?

In my case the DSL speed tests to different servers definitely run in parallel (if I don't defer them with an added delay) as the results add up to the total available bandwidth.

@ssoroka
Copy link
Copy Markdown
Contributor

ssoroka commented Oct 13, 2020

I'd be in favor of adding a configuration option to say whether you want them to run in parallel or not, or maybe a parallelism = n flag to say how many scripts you want to run at once, 1 being serialized.

@ssoroka ssoroka merged commit aa0363e into influxdata:master Oct 13, 2020
@Alestrix Alestrix deleted the patch-1 branch October 13, 2020 23:06
@srebhan
Copy link
Copy Markdown
Member

srebhan commented Oct 14, 2020

The issue with a script file is that the resulting output would be multiple concatenated JSON strings, which is not a correct JSON string anymore. [...]

What happens if you concatenate the JSON objects (jobj1..N) like this [jobj1, jobj2, ...jobjN]? This is valid JSON and the parser should be able to handle this IMO.

reimda pushed a commit that referenced this pull request Oct 21, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/exec docs Issues related to Telegraf documentation and configuration descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants