http_response: status_code match#8032
Merged
reimda merged 3 commits intoinfluxdata:masterfrom Oct 16, 2020
Merged
Conversation
reimda
suggested changes
Aug 26, 2020
Contributor
Author
|
The CI has failed but it's seems to be an error from another plugin, not sure I've an impact on this |
Contributor
Author
|
@reimda They're a way to re-triggrer circleci without commit? |
Contributor
I think only admins can so triggered them. Looks like they passed |
Contributor
|
would it make more sense to instead just record the status code, instead of a binary match/no-match? |
Contributor
Author
The status code is already record under |
reimda
approved these changes
Oct 16, 2020
ssoroka
pushed a commit
that referenced
this pull request
Oct 16, 2020
(cherry picked from commit 527a11a)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
I've added the possibility to match on the status code instead of only the response body, can be useful if your service return a 204.
I'm not fully satisfied because actually we can only check the body OR the status code (not both). Technically isn't difficult to be able to do both, but that require some decisions about the
resultvalue, if only one of these fail the value is pretty obvious but in case both check fail, do we need to create another value (response_mismatch?) or set the field toresponse_status_code_mismatchorresponse_string_mismatchThanks!