Add tags to snmp_trap input for context name and engine ID#7633
Merged
Add tags to snmp_trap input for context name and engine ID#7633
Conversation
danielnelson
reviewed
Jun 5, 2020
danielnelson
approved these changes
Jun 5, 2020
jaecktec
pushed a commit
to jaecktec/telegraf
that referenced
this pull request
Jun 8, 2020
…a#7633) Add tags for the context name and engine ID
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
…a#7633) Add tags for the context name and engine ID
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
…a#7633) Add tags for the context name and engine ID
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
…a#7633) Add tags for the context name and engine ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In V3 traps, the trap sender sends a context name and engine ID. Before this change, telegraf's snmp_trap input passed a context name and engine ID to Gosnmp. Gosnmp doesn't use these when receiving traps, only when sending, so this change removed them. The input now also adds tags for the context name and engine ID that we receive in the trap.
Also clean up variable naming in tests.