Skip to content

Gather all mysql channels#5517

Merged
sspaink merged 15 commits intoinfluxdata:masterfrom
utking:gather-all-mysql-channels
Apr 14, 2021
Merged

Gather all mysql channels#5517
sspaink merged 15 commits intoinfluxdata:masterfrom
utking:gather-all-mysql-channels

Conversation

@utking
Copy link
Copy Markdown
Contributor

@utking utking commented Mar 2, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.

@utking utking marked this pull request as ready for review March 2, 2019 23:45
jtsunne
jtsunne approved these changes Mar 4, 2019
View reviewed changes
Copy link
Copy Markdown

@jtsunne jtsunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

glinton
glinton suggested changes Mar 4, 2019
View reviewed changes
@glinton glinton added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/mysql labels Mar 4, 2019
@glinton glinton added this to the 1.11.0 milestone Mar 5, 2019
@danielnelson danielnelson modified the milestones: 1.11.0, 1.12.0 May 24, 2019
@danielnelson danielnelson modified the milestones: 1.12.0, 1.13.0 Aug 5, 2019
@sjwang90 sjwang90 removed this from the 1.13.0 milestone Nov 15, 2019
@danielmotaleite
Copy link
Copy Markdown

danielmotaleite commented Nov 21, 2019

any change of adding support for mariadb and so fixing bug #6395

@spumer
Copy link
Copy Markdown

spumer commented May 24, 2020

any updates?

@utking
Copy link
Copy Markdown
Contributor Author

utking commented Nov 28, 2020

@glinton - I've updated the PR with MariaDB-related things. I really hope it won't be waiting for another half a year before something else is changed and we need to fix it again and again.
cc @danielmotaleite @spumer

@utking utking mentioned this pull request Nov 28, 2020
Closed
@utking utking requested a review from glinton November 29, 2020 23:36
glinton
glinton reviewed Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay, i haven't been on the telegraf team for a while. @sjwang90 will likely know more about when this can fit in their timeline, so i won't approve or block this.

srebhan
srebhan reviewed Apr 8, 2021
View reviewed changes
srebhan
srebhan reviewed Apr 8, 2021
View reviewed changes
srebhan
srebhan reviewed Apr 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some small comments in the code. The most relevant one is regarding the type-assertion to *sql.RawBytes.

@srebhan srebhan self-assigned this Apr 8, 2021
@utking
Copy link
Copy Markdown
Contributor Author

utking commented Apr 9, 2021

@srebhan I've addressed your comments. Could you please check it now?

srebhan
srebhan approved these changes Apr 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 14, 2021
@sspaink sspaink merged commit e5b7a09 into influxdata:master Apr 14, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
Gather all mysql channels (influxdata#5517)
61e035e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

+3 more reviewers

@glinton glinton glinton approved these changes

@sspaink sspaink sspaink approved these changes

@jtsunne jtsunne jtsunne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

area/mysql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@utking @danielmotaleite @spumer @glinton @sspaink @srebhan @jtsunne @danielnelson @sjwang90