Skip to content

feat(inputs.execd): Allow to provide logging prefixes on stderr#15834

Merged
srebhan merged 3 commits intoinfluxdata:masterfrom
srebhan:execd_issue_9487
Sep 9, 2024
Merged

feat(inputs.execd): Allow to provide logging prefixes on stderr#15834
srebhan merged 3 commits intoinfluxdata:masterfrom
srebhan:execd_issue_9487

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Sep 3, 2024

Summary

Enable more differentiated logging in external plugins by allowing to provide logging indicators and reflecting those levels in the actual logging on Telegraf side. The PR is backward compatible if no indicator is provided.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #9487

@telegraf-tiger telegraf-tiger bot added area/execd Issues related to execd or plugins that would be better suited to be used through execd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 3, 2024
@srebhan srebhan mentioned this pull request Sep 3, 2024
Closed
@srebhan srebhan self-assigned this Sep 3, 2024
Hipska
Hipska suggested changes Sep 4, 2024
View reviewed changes
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 9, 2024
@srebhan srebhan assigned mstrandboge and unassigned srebhan Sep 9, 2024
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Sep 9, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan merged commit b0d44d8 into influxdata:master Sep 9, 2024
@srebhan srebhan deleted the execd_issue_9487 branch September 9, 2024 16:00
@github-actions github-actions bot added this to the v1.32.0 milestone Sep 9, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@srebhan @asaharn
feat(inputs.execd): Allow to provide logging prefixes on stderr (infl…
9007d9a 
…uxdata#15834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstrandboge mstrandboge mstrandboge approved these changes

+1 more reviewer

@Hipska Hipska Hipska approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mstrandboge mstrandboge

Labels

area/execd Issues related to execd or plugins that would be better suited to be used through execd area/logging feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.32.0

Development

Successfully merging this pull request may close these issues.

Log handling for external plugins

3 participants

@srebhan @Hipska @mstrandboge