fix(inputs.kube_inventory): send file location to enable token auto-refresh#11577
Merged
powersj merged 3 commits intoinfluxdata:masterfrom Aug 2, 2022
Merged
fix(inputs.kube_inventory): send file location to enable token auto-refresh#11577powersj merged 3 commits intoinfluxdata:masterfrom
powersj merged 3 commits intoinfluxdata:masterfrom
Conversation
…efresh Currently, Telegraf will read a token file and provide that as a string to the K8s client. This will prevent the K8s client from attempting to auto-refresh the token. In newer versions of K8s, tokens will expire every hour as a security measure. This instead will pass the file location rather than having telegraf read it directly. Becuase of this new K8s behavior, this also deprecates and warns the user when using a hard-coded string token. fixes: influxdata#11267
srebhan
reviewed
Aug 2, 2022
Member
srebhan
left a comment
There was a problem hiding this comment.
Looks good to me. I only think it's helpful to add a sentence about deprecation of bearer_token to the sample.conf file.
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
MyaLongmire
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Telegraf will read a token file and provide that as a string
to the K8s client. This will prevent the K8s client from attempting to
auto-refresh the token. In newer versions of K8s, tokens will expire
every hour as a security measure.
This, instead will pass the file location rather than having telegraf
read it directly. Because of this new K8s behavior, this also deprecates
and warns the user when using a hard-coded string token.
fixes: #11267