chore(inputs.ntpq): Cleanup existing plugin#11575
Merged
srebhan merged 10 commits intoinfluxdata:masterfrom Aug 1, 2022
Merged
chore(inputs.ntpq): Cleanup existing plugin#11575srebhan merged 10 commits intoinfluxdata:masterfrom
srebhan merged 10 commits intoinfluxdata:masterfrom
Conversation
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
approved these changes
Aug 1, 2022
Contributor
powersj
left a comment
There was a problem hiding this comment.
This looks much, much cleaner, thank you!
MyaLongmire
approved these changes
Aug 1, 2022
reimda
pushed a commit
that referenced
this pull request
Aug 15, 2022
(cherry picked from commit 9f57f94)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial cleanup in order to be able to implement more features (see #7840) easily. As a summary, the PR first simplifies the
Gather()function and the construction of thentpqcommand. Furthermore, it moves all test-case data out into actual test-cases similar to the ones inparsers/json. This allows to easily add test-cases and keeps the data separate from the code.