Skip to content

test: fix opentelemetry test#11573

Merged
powersj merged 1 commit intoinfluxdata:masterfrom
coralogix:fix-up-tests
Aug 2, 2022
Merged

test: fix opentelemetry test#11573
powersj merged 1 commit intoinfluxdata:masterfrom
coralogix:fix-up-tests

Conversation

@povilasv
Copy link
Copy Markdown
Contributor

@povilasv povilasv commented Aug 1, 2022 •
edited
Loading

Required for all PRs

resolves #

Fixes opentelemetry test mock server returning:

 rpc error: code = Internal desc = grpc: error while marshaling: proto: Marshal called

See the deleted comment for more details

@telegraf-tiger telegraf-tiger bot added the test label Aug 1, 2022
srebhan
srebhan reviewed Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @povilasv for your fix! One small comment from my side...

@srebhan srebhan self-assigned this Aug 1, 2022
@srebhan srebhan added area/telemetry All about OpenTelemetry and other telemetry variants plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Aug 1, 2022
@povilasv
Copy link
Copy Markdown
Contributor Author

povilasv commented Aug 2, 2022

Thanks for review @srebhan , updated the PR ;)

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Aug 2, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for cleaning this up @povilasv!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 2, 2022
powersj
powersj approved these changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@powersj powersj merged commit 272a0a3 into influxdata:master Aug 2, 2022
@povilasv povilasv deleted the fix-up-tests branch August 3, 2022 06:43
reimda pushed a commit that referenced this pull request Aug 15, 2022
@povilasv @reimda
test: fix openetelemtry test (#11573)
7da8373 
(cherry picked from commit 272a0a3)
reimda pushed a commit that referenced this pull request Aug 16, 2022
@povilasv @reimda
test: fix openetelemtry test (#11573)
8663f9b 
(cherry picked from commit 272a0a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

+1 more reviewer

@powersj powersj powersj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

area/telemetry All about OpenTelemetry and other telemetry variants plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@povilasv @powersj @srebhan