fix(json_v2): use raw values for timestamps#10413
Merged
Conversation
Contributor
|
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
powersj
approved these changes
Jan 11, 2022
Contributor
powersj
left a comment
There was a problem hiding this comment.
Thank you very much for jumping on this and fixing it!
powersj
pushed a commit
to powersj/telegraf
that referenced
this pull request
Jan 21, 2022
reimda
pushed a commit
that referenced
this pull request
Jan 27, 2022
(cherry picked from commit 18704de)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #10405
Similar to: #7555, the timestamps need to use the raw value or it might truncate the configured timestamp. Also updated the timestamp tests to compare the resulting timestamps, had to update the tests slightly to handle that the milliseconds and timezone weren't right.