Skip to content

fix: Fix missing disks in container#10318

Merged
powersj merged 7 commits intoinfluxdata:masterfrom
HRI-EU:fix_10297
Jan 5, 2022
Merged

fix: Fix missing disks in container#10318
powersj merged 7 commits intoinfluxdata:masterfrom
HRI-EU:fix_10297

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Dec 21, 2021

Required for all PRs:

resolves #10297

This PR fixes the missing disks when trying to run telegraf from within a container.

@srebhan srebhan changed the title fix:Fix missing disks in container fix: Fix missing disks in container Dec 21, 2021
@srebhan srebhan mentioned this pull request Dec 21, 2021
Closed
@srebhan srebhan marked this pull request as ready for review December 22, 2021 12:05
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Dec 22, 2021

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb s390x.rpm linux_amd64.tar.gz
mipsel.deb x86_64.rpm linux_arm64.tar.gz
ppc64el.deb linux_armel.tar.gz
s390x.deb linux_armhf.tar.gz
linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj merged commit 7867ef3 into influxdata:master Jan 5, 2022
powersj pushed a commit that referenced this pull request Jan 5, 2022
@srebhan @powersj
fix: fix missing storage in container with disk plugin (#10318)
b5426b9 
(cherry picked from commit 7867ef3)
@srebhan srebhan mentioned this pull request Jan 11, 2022
Closed
@voiprodrigo
Copy link
Copy Markdown
Contributor

voiprodrigo commented Jan 19, 2022

After this change, logs are plagued with this type of messages:

2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] partition 0: {"device":"sysfs","mountpoint":"/sys","fstype":"sysfs","opts":["rw","nosuid","nodev","noexec","relatime"]}
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] -> using mountpoint "/sys"...
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] => kept...
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] partition 1: {"device":"proc","mountpoint":"/proc","fstype":"proc","opts":["rw","nosuid","nodev","noexec","relatime"]}
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] => dropped by filesystem-type filter
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] partition 2: {"device":"devtmpfs","mountpoint":"/dev","fstype":"devtmpfs","opts":["rw","nosuid"]}
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] => dropped by filesystem-type filter

powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@srebhan @powersj
fix: fix missing storage in container with disk plugin (influxdata#10318
06b4e51 
)
@srebhan
Copy link
Copy Markdown
Member Author

srebhan commented Jan 24, 2022

@voiprodrigo as you can see those are debug messages. Is there any reason you are running in debug mode?

@voiprodrigo
Copy link
Copy Markdown
Contributor

voiprodrigo commented Jan 24, 2022

@srebhan I know they're debug. Still, I feel these look as "debug during development/bug fixing", not "debugging in production". Mostly because of the buffer messages, I like to keep an eye on those.

@srebhan
Copy link
Copy Markdown
Member Author

srebhan commented Jan 24, 2022

@voiprodrigo can you please open an issue to discuss possible solutions there?

@srebhan srebhan mentioned this pull request Jan 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@powersj powersj powersj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Telegraf 1.21.1, input plugin disk doesn't report data for non-partitioned disks

3 participants

@srebhan @voiprodrigo @powersj