Skip to content

fix: Fix panic in parsers due to missing Log#10288

Merged
reimda merged 1 commit intoinfluxdata:masterfrom
HRI-EU:fix_parsers
Dec 16, 2021
Merged

fix: Fix panic in parsers due to missing Log#10288
reimda merged 1 commit intoinfluxdata:masterfrom
HRI-EU:fix_parsers

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Dec 16, 2021

resolves #10285
resolves #10286

Plugins using the SetParserFunc do not initialize the parsers' Log field properly (nor do they call Init()). This PR fixes the resulting panic by doing the initialization properly.

A quick search shows that file, tail and directory_monitor seem to be hit by this bug.

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Dec 16, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Dec 16, 2021
@srebhan srebhan added the plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins label Dec 16, 2021
@srebhan
Copy link
Copy Markdown
Member Author

srebhan commented Dec 16, 2021

!signed-cla

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Dec 16, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Dec 16, 2021

👍 This pull request doesn't change the Telegraf binary size

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb s390x.rpm linux_amd64.tar.gz
mipsel.deb x86_64.rpm linux_arm64.tar.gz
ppc64el.deb linux_armel.tar.gz
s390x.deb linux_armhf.tar.gz
linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

This was referenced Dec 16, 2021
Closed
Closed
@srebhan
Copy link
Copy Markdown
Member Author

srebhan commented Dec 16, 2021

!signed-cla

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Dec 16, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@tarjei
Copy link
Copy Markdown

tarjei commented Dec 16, 2021

I tested this PR and it fixed #10285 for me.

@hluaces
Copy link
Copy Markdown

hluaces commented Dec 16, 2021

In #10286 I provided a Dockerfile that reproduced the issue.

With the artifact provided on this PR for RPM-based x86_64 systems the issue seems to be solved.

MyaLongmire
MyaLongmire approved these changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@reimda reimda merged commit d1d81b7 into influxdata:master Dec 16, 2021
reimda pushed a commit that referenced this pull request Dec 16, 2021
@srebhan @reimda
fix: Fix panic in parsers due to missing Log for all plugins using Se…
ae4cae9 
…tParserFunc. (#10288)

(cherry picked from commit d1d81b7)
reimda pushed a commit that referenced this pull request Dec 16, 2021
@srebhan @reimda
fix: Fix panic in parsers due to missing Log for all plugins using Se…
fd6d793 
…tParserFunc. (#10288)

(cherry picked from commit d1d81b7)
@tarjei
Copy link
Copy Markdown

tarjei commented Dec 17, 2021

@srebhan when do you think this will be in a new release?

@srebhan
Copy link
Copy Markdown
Member Author

srebhan commented Dec 17, 2021

@tarjei there will be a 1.21.1 release, not exactly sure when...

@srebhan
Copy link
Copy Markdown
Member Author

srebhan commented Dec 17, 2021

@tarjei oh it's already on the Download page... :-)

powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@srebhan @powersj
fix: Fix panic in parsers due to missing Log for all plugins using Se…
892c947 
…tParserFunc. (influxdata#10288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@powersj powersj powersj approved these changes

@MyaLongmire MyaLongmire MyaLongmire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Telegraf 1.21.0 - segmentation violation when using logparser SIGSEV inputs.tail w/grok crashes in 1.21.0

6 participants

@srebhan @tarjei @hluaces @powersj @MyaLongmire @reimda