feat: Add option to disable Wavefront prefix conversion#10252
Merged
powersj merged 2 commits intoinfluxdata:masterfrom Dec 14, 2021
homedepot:serializer-wavefront-update
Merged
feat: Add option to disable Wavefront prefix conversion#10252powersj merged 2 commits intoinfluxdata:masterfrom homedepot:serializer-wavefront-update
powersj merged 2 commits intoinfluxdata:masterfrom
homedepot:serializer-wavefront-update
Conversation
Maintaining the default behavior for backwards compatibility, while adding the option of preserving original metric prefixes.
Contributor
Author
Contributor
Author
Contributor
|
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
bool-literal-in-expr: omit Boolean literal in expression (revive)
srebhan
approved these changes
Dec 9, 2021
Member
srebhan
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for your work @crflanigan and @zachmares!
powersj
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintaining the default behavior for backwards compatibility, while adding the option of preserving original metric prefixes.
Required for all PRs:
resolves #7913
Users who use the Wavefront serializer who don't wish to have their metric prefixes modified may configure their output plugin in a similar way as the Wavefront Output Plugin.
Users may set the following configuration option:
wavefront_disable_prefix_conversion = trueDefault behavior (enabled prefix/path conversion):
prod.prefix.name.metric.nameConfigurable behavior (disabled prefix/path conversion):
prod.prefix_name.metric_name