feat: Update Stream to accept a bufSize for tar CopyBuffer window (#26964)#27077
Merged
feat: Update Stream to accept a bufSize for tar CopyBuffer window (#26964)#27077
Conversation
…6964) `io.Copy` & `io.CopyN` uses a default window size of 32KB during copy `Copy(N)` calls `copyBuffer` with `buf` set to `nil` https://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/io/io.go;l=387-389 When `buf` is `nil` go will set the default buffer size to 32KB https://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/io/io.go;l=418 This PR replaces `io.CopyN` with `io.CopyBuffer` in `tar.Stream`. It also adds a new configuration value `tar-stream-buffer-size` which can be adjusted to allow for larger or smaller tar buffer sizes to be used during backup operations. It is suggested to keep the default as is, while testing different buffer sizes to be used with `CopyBuffer` I found that `1MB` was the best performance-wise. (cherry picked from commit abd617f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io.Copy&io.CopyNuses a default window size of 32KB during copyCopy(N)callscopyBufferwithbufset tonilhttps://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/io/io.go;l=387-389When
bufisnilgo will set the default buffer size to 32KB https://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/io/io.go;l=418This PR replaces
io.CopyNwithio.CopyBufferintar.Stream. It also adds a new configuration valuetar-stream-buffer-sizewhich can be adjusted to allow for larger or smaller tar buffer sizes to be used during backup operations.It is suggested to keep the default as is, while testing different buffer sizes to be used with
CopyBufferI found that1MBwas the best performance-wise.(cherry picked from commit abd617f)