Merged
Conversation
During the upgrade there was a change to string format analysis https://go.dev/doc/go1.24#vet requiring changes to any format strings.
Add '.' argument to stringer directives to properly specify package context. This fixes 'internal error: package without types' errors with stringer in Go 1.24+. Files modified: - cmd/influx_tools/internal/format/binary/common.go - models/gen.go - pkg/data/gen/gen.go Also regenerates string files with updated stringer version.
Updates golang.org/x/tools and related dependencies to versions compatible with Go 1.24+. This is required for stringer to work correctly with the new Go version.
jdstrand
reviewed
Oct 21, 2025
Contributor
jdstrand
left a comment
There was a problem hiding this comment.
One question in-line regarding correctness.
| return "MessageType(" + strconv.FormatInt(int64(i+1), 10) + ")" | ||
| idx := int(i) - 1 | ||
| if i < 1 || idx >= len(_MessageType_index)-1 { | ||
| return "MessageType(" + strconv.FormatInt(int64(i), 10) + ")" |
Contributor
There was a problem hiding this comment.
This doesn't look look the same, am I missing something? Why are we now returning int64(i) here instead of int64(i+1)?
Author
There was a problem hiding this comment.
This code is auto-generated by stringer, it must have changed slightly with the newer version of go. 🤔
Contributor
There was a problem hiding this comment.
If you deem it correct, then +1 from me
1 task
updates formatter variants to use non-format var
davidby-influx
approved these changes
Oct 29, 2025
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
LGTM. I was initially confused by moving from fmt.Fprintf(string) to fmt.Fprintf("%s", string) to fmt.Fprint(string) but I finally got it.
devanbenz
added a commit
that referenced
this pull request
Oct 31, 2025
(cherry picked from commit f60c5c4)
devanbenz
added a commit
that referenced
this pull request
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the upgrade there was a change to string format analysis https://go.dev/doc/go1.24#vet requiring changes to any format strings that did not meet the new vet requirements.