feat: Adds LastModifiedOrErr to expose error for LastModified#26623
Merged
devanbenz merged 3 commits intomaster-1.xfrom Jul 25, 2025
Merged
feat: Adds LastModifiedOrErr to expose error for LastModified#26623devanbenz merged 3 commits intomaster-1.xfrom
devanbenz merged 3 commits intomaster-1.xfrom
Conversation
gwossum
reviewed
Jul 23, 2025
gwossum
reviewed
Jul 23, 2025
gwossum
reviewed
Jul 23, 2025
gwossum
reviewed
Jul 23, 2025
gwossum
reviewed
Jul 23, 2025
Member
gwossum
left a comment
There was a problem hiding this comment.
Implementation looks correct, but a few comments for possible improvements.
devanbenz
added a commit
that referenced
this pull request
Jul 25, 2025
(cherry picked from commit 0f57087)
devanbenz
added a commit
that referenced
this pull request
Sep 26, 2025
(cherry picked from commit 0f57087)
devanbenz
added a commit
that referenced
this pull request
Sep 26, 2025
This was referenced Dec 23, 2025
devanbenz
added a commit
that referenced
this pull request
Jan 26, 2026
(cherry picked from commit 0f57087)
devanbenz
added a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we do not expose the error thrown by Shard.LastModified, this PR will add
Shard.LastModifiedOrErrwhich will expose the actual error when it's called.