Merged
Conversation
This commit ports metrics around merging tsm blocks when executing a query. These will appear in EXPLAN ANALYZE results. The new information records the time spent merging blocks, the number of blocks merged, roughly the number of values merged into the first block of each ReadBlock call, and the number of times that single calls to ReadBlock have more than 4 block merges. The multiblock merge is sequential and might benefit from a tree merge algorithm. The latter stat helps identify if the engineering effort would be fruitful. * closes #26614
Contributor
Author
|
example explain analyze |
Member
|
@philjb Overall, I love adding these metrics and look forward to having them in future versions. However, the new timers are in ns, which I don't love, especially since the other timers are in ms. I assume you're using |
Contributor
Author
You mean in that execution_time for example is printed as a Duration with nicer units than nanoseconds? I think i might be able to handle that. lemme see. If you meant something else, let me know. |
Member
@philjb Yes, change |
Contributor
Author
|
Ok - switched to timers. The values print at the bottom now tho |
gwossum
reviewed
Jul 17, 2025
gwossum
reviewed
Jul 17, 2025
gwossum
approved these changes
Jul 18, 2025
Member
gwossum
left a comment
There was a problem hiding this comment.
LGTM. I'll create an issue to backport this to 1.12 once 1.12.1 is released.
devanbenz
pushed a commit
that referenced
this pull request
Jul 25, 2025
* feat(1.x,file_store): port metrics for merge work This commit ports metrics around merging tsm blocks when executing a query. These will appear in EXPLAN ANALYZE results. The new information records the time spent merging blocks, the number of blocks merged, roughly the number of values merged into the first block of each ReadBlock call, and the number of times that single calls to ReadBlock have more than 4 block merges. The multiblock merge is sequential and might benefit from a tree merge algorithm. The latter stat helps identify if the engineering effort would be fruitful. * closes #26614 * chore: switch to a timer for duration printing of times * chore: rename method * fix: avoid race and use new atomic primitive (cherry picked from commit 4e8a3b3)
devanbenz
pushed a commit
that referenced
this pull request
Jul 25, 2025
* feat(1.x,file_store): port metrics for merge work This commit ports metrics around merging tsm blocks when executing a query. These will appear in EXPLAN ANALYZE results. The new information records the time spent merging blocks, the number of blocks merged, roughly the number of values merged into the first block of each ReadBlock call, and the number of times that single calls to ReadBlock have more than 4 block merges. The multiblock merge is sequential and might benefit from a tree merge algorithm. The latter stat helps identify if the engineering effort would be fruitful. * closes #26614 * chore: switch to a timer for duration printing of times * chore: rename method * fix: avoid race and use new atomic primitive (cherry picked from commit 4e8a3b3)
devanbenz
pushed a commit
that referenced
this pull request
Sep 24, 2025
* feat(1.x,file_store): port metrics for merge work This commit ports metrics around merging tsm blocks when executing a query. These will appear in EXPLAN ANALYZE results. The new information records the time spent merging blocks, the number of blocks merged, roughly the number of values merged into the first block of each ReadBlock call, and the number of times that single calls to ReadBlock have more than 4 block merges. The multiblock merge is sequential and might benefit from a tree merge algorithm. The latter stat helps identify if the engineering effort would be fruitful. * closes #26614 * chore: switch to a timer for duration printing of times * chore: rename method * fix: avoid race and use new atomic primitive (cherry picked from commit 4e8a3b3)
devanbenz
added a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ports metrics around merging tsm blocks when executing a query. These will appear in EXPLAN ANALYZE results. The new information records the time spent merging blocks, the number of blocks merged, roughly the number of values merged into the first block of each ReadBlock call, and the number of times that single calls to ReadBlock have more than 4 block merges. The multiblock merge is sequential and might benefit from a tree merge algorithm. The latter stat helps identify if the engineering effort would be fruitful.