fix: stop noisy logging about phantom shards that do not belong to node#26527
Merged
gwossum merged 1 commit intomaster-1.xfrom Jun 17, 2025
Merged
fix: stop noisy logging about phantom shards that do not belong to node#26527gwossum merged 1 commit intomaster-1.xfrom
gwossum merged 1 commit intomaster-1.xfrom
Conversation
Stop noisy logging about phantom shards that do not belong to the current node by checking the shard ownership before logging about the phantom shard. Note that only the logging was inaccurate. This did not accidentally remove shards from the metadata that weren't really phantom shards due to checks in `DropShardMetaRef` implementations. closes: #26525
davidby-influx
approved these changes
Jun 16, 2025
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
LGTM.
Should you make a 1.12 cherry-pick place-holder issue? 2.x?
Member
Author
|
Yes, this should be cherry-picked to 1.12, and probably 1.11. It wouldn't hurt to cherry pick it to 2.x, but because 2.x is single node it doesn't suffer from the same issue. The issue only shows up in multi-node systems. |
This was referenced Jun 17, 2025
Closed
devanbenz
pushed a commit
that referenced
this pull request
Sep 24, 2025
…de (#26527) Stop noisy logging about phantom shards that do not belong to the current node by checking the shard ownership before logging about the phantom shard. Note that only the logging was inaccurate. This did not accidentally remove shards from the metadata that weren't really phantom shards due to checks in `DropShardMetaRef` implementations. closes: #26525 (cherry picked from commit 8ef2aca)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop noisy logging about phantom shards that do not belong to the current node by checking the shard ownership before logging about the phantom shard. Note that only the logging was inaccurate. This did not accidentally remove shards from the metadata that weren't really phantom shards due to checks in
DropShardMetaRefimplementations.closes: #26525