fix: Automatic intermediate directory cleanup for file object store#26480
Merged
stuartcarnie merged 1 commit intomainfrom Jun 2, 2025
Merged
fix: Automatic intermediate directory cleanup for file object store#26480stuartcarnie merged 1 commit intomainfrom
stuartcarnie merged 1 commit intomainfrom
Conversation
Removes empty intermediate directories when a key is removed from local file system object storage, which matches cloud-based providers.
waynr
approved these changes
Jun 2, 2025
hiltontj
approved these changes
Jun 2, 2025
pauldix
approved these changes
Jun 2, 2025
mgattozzi
added a commit
that referenced
this pull request
Sep 8, 2025
* fix: Automatic intermediate directory cleanup for file object store (#26480) Removes empty intermediate directories when a key is removed from local file system object storage, which matches cloud-based providers. * feat: add retention period to catalog (#26479) * feat: add retention period to catalog * fix: handle humantime parsing error properly * refactor: use new iox_http_util types --------- Co-authored-by: Michael Gattozzi <mgattozzi@influxdata.com> * chore: address a couple post-merge PR comments (#26489) * feat: add concurrency limit for WAL replay (#26483) WAL replay currently loads _all_ WAL files concurrently running into OOM. This commit adds a CLI parameter `--wal-replay-concurrency-limit` that would allow the user to set a lower limit and run WAL replay again. closes: #26481 --------- Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com> Co-authored-by: Michael Gattozzi <mgattozzi@influxdata.com> Co-authored-by: praveen-influx <pkumar@influxdata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes empty intermediate directories when a key is removed from local file system object storage, which matches cloud-based providers.
Prior to this comment, when using the
fileobject store, if the two keys (12.parquet, 9.json) are deleted:The on-disk structure will leave an orphaned intermediate directory structure
/Volumes/RAMDisk/influxdb3_pro/ingest/c/4c/537/cb4:However, cloud-based object stores don't store the intermediate directories. With the additional flag in this PR, the empty intermediate directories are also removed, resulting in the following: