fix: update token creation output#26336
Merged
peterbarnett03 merged 5 commits intomainfrom Apr 30, 2025
Merged
Conversation
stuartcarnie
requested changes
Apr 28, 2025
Contributor
stuartcarnie
left a comment
There was a problem hiding this comment.
LGTM, but you'll have to fix the linter issue
Contributor
Author
|
Lints fixed. Also, switched to using a current crate we use (owo_colors) rather than embedded ANSI for obvious best practice. |
pauldix
approved these changes
Apr 28, 2025
praveen-influx
approved these changes
Apr 28, 2025
Contributor
praveen-influx
left a comment
There was a problem hiding this comment.
LGTM - thanks for updating the wording.
hiltontj
pushed a commit
that referenced
this pull request
May 2, 2025
* fix: clarify token generation output for easier readibility * fix: linter error * fix: additional linter error * fix: linter error on output * fix: switch to owo_colorize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the output to more clearly identify the success of the command, the output of the command, and the importance of storing the token.
Uses ANSI for styling, so it's non-terminal specific, but requires Regex for parsing now.
Current vs New
Current Output
The current design is very nondescript, doesn't mention the importance of saving the token, and is easily lost as CLI outputs and commands grow.
New Output
The new design is specifically calls out success of creating a token, more cleanly identifies the token itself, and also very clearly mentions that it should be stored securely.
Alternatives Considered
Additional Coloring
The green could have been helpful, but I feel pollutes the UX with too much visual overload with an additional color.
Boxing
Additionally, tried an example with the left bars to more cleanly display results. This looks nice, but on smaller terminals it would force wrap arounds which simply would look far less clean than not at all.
