test: distinct cache ignores rows with nulls#26306
Merged
Conversation
2 tasks
| cat.create_distinct_cache( | ||
| TestWriter::DB_NAME, | ||
| "bar", | ||
| Some("cache_money"), |
praveen-influx
approved these changes
Apr 22, 2025
Contributor
praveen-influx
left a comment
There was a problem hiding this comment.
LGTM - but I'm not sure about the linked GH issue, if you choose to not merge this in that is fine.
Contributor
Author
|
Thanks @praveen-influx - I merged for now, since this does check that the cache is fulfilling its original requirements. If we decide to allow |
hiltontj
added a commit
that referenced
this pull request
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25564
Adds a test that checks the behaviour of the distinct cache with respect to null values. Currently, the distinct cache ignores rows that have
NULLfor any of the cached columns.