fix: Ensure iox table schema is sorted for SHOW TABLES#26302
Merged
stuartcarnie merged 3 commits intomainfrom Apr 22, 2025
Merged
fix: Ensure iox table schema is sorted for SHOW TABLES#26302stuartcarnie merged 3 commits intomainfrom
iox table schema is sorted for SHOW TABLES#26302stuartcarnie merged 3 commits intomainfrom
Conversation
hiltontj
approved these changes
Apr 22, 2025
Contributor
hiltontj
left a comment
There was a problem hiding this comment.
LGTM - but you will need to address clippy lints.
Contributor
Author
|
Thanks @hiltontj – all done! |
hiltontj
pushed a commit
that referenced
this pull request
May 2, 2025
* fix: Ensure `iox` table schema is sorted for SHOW TABLES Closes #25860 * chore: Add insta snapshot * chore: placate clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25860
Teaches the
ioxtable provider to sort the output of thetable_namesAPI, so thatSHOW TABLESsorts the output.Testing
Introduced a new unit test to verify the output is sorted for
SHOW TABLES