docs: clarify default maxes for distinct cache#26281
Merged
peterbarnett03 merged 1 commit intomainfrom Apr 16, 2025
Merged
Conversation
9c2debf to
ff0f97b
Compare
hiltontj
approved these changes
Apr 16, 2025
|
|
||
| /// The maximum age of an entry in the cache entered as a human-readable duration, e.g., "30d", "24h" | ||
| #[clap(long = "max-age")] | ||
| #[clap(long = "max-age", default_value = "1d")] |
Contributor
There was a problem hiding this comment.
The default should already have been 1 day:
I guess this is just for the purpose of documentation? Since, the coded default doesn't appear in the CLI output anywhere.
Contributor
Author
There was a problem hiding this comment.
Yeah, had a user running into issues because it makes it 1d if you don't specify and they were loading in historical data, so they didn't know why they weren't seeing the data. Something we should probably make more clear or revisit in general, but a small update for now.
hiltontj
pushed a commit
that referenced
this pull request
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny PR. Clarifies that the default max age for a Distinct Cache is 1d (86000 seconds) and default max cardinality is 100000.
Will have to move this into the new CLI help eventually.
No ticket. Based on user feedback.